Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Asuka https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199919 ------- Additional Comments From paul@xxxxxxxxxxxx 2006-07-25 05:22 EST ------- (In reply to comment #4) > rpmlint gave errors on SRPM as > > W: asuka strange-permission asuka-init 0755 > A file that you listed to include in your package has strange > permissions. Usually, a file should have 0644 permissions. > ==> I dont know why rpmlint reported warning here. This is correct Not really. The initscript is just a regular source file and does not need to be executable in the SRPM. It gets installed with the right permissions anyway during the %install part of the build. In addition to all of the other comments in Comment #4, I'd also suggest: * using "|| :" at the end of each command in the scriptlets (see the "Tips for new recipes" at the bottom of http://fedoraproject.org/wiki/ScriptletSnippets) * If there is any chance of the package leaving behind files owned by the userid created in this package (irc), don't remove the user and group when the package is erased. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review