Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Asuka https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199919 ------- Additional Comments From panemade@xxxxxxxxx 2006-07-25 05:12 EST ------- rpmlint gave errors on SRPM as W: asuka strange-permission asuka-init 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. ==> I dont know why rpmlint reported warning here. This is correct W: asuka hardcoded-packager-tag Tim The Packager tag is hardcoded in your spec file. It should be removed, so as to use rebuilder's own defaults. ==> No Packager tag is used in Fedoras SPECs. So remove it. W: asuka redundant-prefix-tag The Prefix tag is uselessly defined as %{_prefix} in your spec file. It should be removed, as it is redundant with rpm defaults. ==>Don't define again %{_prefix} as its standard macro. Remove Prefix: %{_prefix} line from SPEC E: asuka use-of-RPM_SOURCE_DIR You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use a directory for building, use $RPM_BUILD_ROOT instead. ==> Don't use macro $RPM_SOURCE_DIR instead use $RPM_BUILD_ROOT * Also, Change line from BuildRoot: %{_tmppath}/%{name}-root to BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * Provide Source URL to download source tarball. * You don't need to have line mkdir -p $RPM_BUILD_ROOT * You need to add dist tag to release * try to use macros You would like to see http://fedoraproject.org/wiki/Packaging/Guideline for more information on packaging. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review