Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-sqlite3 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193071 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-07-10 20:58 EST ------- If you really would prefer to type seven characters, five of which require the shift key, instead of two for zero gain, then you're free to do so but you should be consistent. Personally my eyes start to bleed and my wrists start to ache in empathy everytime someone uses a ton of needless macros. However, even the specfile templates aren't consistent about this. (See, for example, the python spec which uses "rm" and "%{__python}" on consecutive lines.) In any case, the latest package looks good to me. The only issue that hasn't been addressed is that of the test suite; obviously we can't run it as is, but now that we have functional guidelines, perhaps it will eventually be packaged up and this package can then run its test suite. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review