Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-sqlite3 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193071 ------- Additional Comments From paul@xxxxxxxxxxxx 2006-07-10 17:49 EST ------- (In reply to comment #8) > You are right about following the guidelines very closely. I have fixed the > ruby_site* macros to coincide with the guidelines (no dir at the end, Ville > Skyttae pointed out that all outher scripting languages use _sitelib, not > _sitelibdir, so let's stick with that) > > As for using %{__chmod}, %{__rm} vs chmod, rm, I am open to either, though I am > never quite sure what the recommended one is, and whether it is correct to rely > on the $PATH of the user building the RPM. It's up to you but be consistent about it. My personal preference is not to trust the user's $PATH and use either macros or full paths for commands that don't have macros. I think from Jason's "obsfucating macro" terminology that his preference lies the other way... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review