Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-DateTime-Format-Strptime https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197736 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-07-06 18:42 EST ------- * source files match upstream: fcda7127b01dcad43ca7cf30be9a1dc6 DateTime-Format-Strptime-1.0700.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent. * noarch package; no debuginfo. * final provides and requires are sane: perl(DateTime::Format::Strptime) = 1.0700 perl-DateTime-Format-Strptime = 1.0700-1.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(DateTime) perl(DateTime::Locale) perl(DateTime::TimeZone) perl(Exporter) perl(Params::Validate) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=7, Tests=373, 2 wallclock secs ( 1.30 cusr + 0.15 csys = 1.45 CPU) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review