Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogre - Object-Oriented Graphics Rendering Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196740 ------- Additional Comments From wart@xxxxxxxxxx 2006-07-06 18:36 EST ------- rpmlint warnings: W: ogre-devel no-documentation - Can be safely ignored since docs are in a -doc subpackage. E: ogre-devel invalid-soname /usr/lib64/libOgrePlatform.so libOgrePlatform.so - Not sure where this is coming from. MUST ==== * Package/spec named appropriately * GPL license ok, license file included * spec file legible and in Am. English * Builds on FC6-i386, FC6-x86_64, FC5-i386, FC5-x86_64 * Sources match upstream: 6ff98b1f14ca679ceaeec00daff2ff87 ogre-linux_osx-v1-2-1.tar.bz2 * No locales * ldconfig called correctly from %post/%postun * Not relocatable * RPM_BUILD_ROOT cleaned as needed * headers, unversioned .so, and pkgconfig files in -devel subpackage * No libtool archives * Does not own any directories that it should not. * No .desktop file needed MUSTFIX ======= * The 'tr' trick in Source0: is cute, but my preference is to limit macro substitutions in Source0 to simple %{name} and %{version} only. Anything more complicated (like spawning subshells) becomes harder to read. In this case, just hard code the version string. * -devel subpackage should use full version in base package dependency (it is missing -%{release}), or add a comment why it's not needed: Requires: %{name} = %{version}-%{release} * BR: flex, bison seem to be unnecessary. COMMENTS ======== * One duplicate file found: Docs/styles.css. This is ok, however, as it is needed for the docs in both the base and the -devel-doc subpackage -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review