Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: clips - Tools for developing expert systems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195420 gemi@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From gemi@xxxxxxxxxx 2006-06-23 16:23 EST ------- + package meets naming and packaging guidelines + specfile is properly named, is cleanly written and uses macros consistently + dist tag is present + build root is correct + license field matches the actual license + license is open source-compatible + source files match upstream: ccba9d912375e57a1b7d9eba12da4198 clipssrc.tar.Z + latest version is being packaged. + BuildRequires are proper. + package builds in mock (i386). + rpmlint: W: clips no-documentation W: clips-devel no-dependency-on clips W: clips-devel no-documentation W: clips-xclips no-documentation these can be ignored. + shared libraries in clips-libs, ldconfig in %post and %postun + link libraries and include files in clips-devel + package is not relocatable. + owns the directories it creates + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + %clean is present. + no scriptlets present. + docs are large, therefore -doc subpackage. + xclips is a GUI app, icon and .desktop file are included this must be fixed: ? pkg-config clips-6 --libs results in: /usr/lib -L -lm -lclips replace "Libs: -lm -L ${libdir} -lclips" with "Libs: -lm -L${libdir} -lclips" (without the space) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review