Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xwrits https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193479 ------- Additional Comments From kevin@xxxxxxxxx 2006-06-19 22:46 EST ------- Sorry I didn't get to this review this weekend... Here's a review. OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: d49fbcc02dc09d1586281f3b294245da xwrits-2.22.tar.gz d49fbcc02dc09d1586281f3b294245da xwrits-2.22.tar.gz.1 OK - Package compiles and builds on at least one arch. n/a - Package needs ExcludeArch OK - BuildRequires correct n/a - Spec handles locales/find_lang n/a - Spec has needed ldconfig in post and postun n/a - Package is relocatable and has a reason to be. OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. See below - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. n/a - -doc subpackage needed/used. OK - Packages %doc files don't affect runtime. n/a - Headers/static libs in -devel subpackage. n/a - .pc files in -devel subpackage. n/a - .so files in -devel subpackage. n/a - -devel package Requires: %{name} = %{version}-%{release} n/a - .la files are removed. OK - Package is a GUI app and has a .desktop file OK - Package doesn't own any directories other packages own. See Below - No rpmlint output. Issues: 1. Some rpmlint output: W: xwrits no-version-in-last-changelog Suggest: add "2.22-2" to the end of the * Sun May 28 2006 Jeff Layton <jlayton@xxxxxxxxxx> line. E: xwrits non-standard-dir-perm /usr/share/doc/xwrits-2.22 0644 Suggest: don't set a default perm in files... %defattr(0644,root,root) should be just %defattr(-,root,root) W: xwrits non-standard-dir-in-usr man Suggest: Don't specify full path for man page: /usr/man/man1/xwrits.1* should be: %{_mandir}/man1/* W: xwrits empty-%post Suggest: remove empty %post section? E: xwrits configure-without-libdir-spec Suggest: add '--libdir=${_libdir}' to the configure step. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review