Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Openbox https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195292 ------- Additional Comments From kaboom@xxxxxxxxxxx 2006-06-19 09:37 EST ------- For the desktop file, I'd say make it non-executable until someone finds a reason it has to be executable. I'll see if I can find more on that one For the conditionalization, etc. that's personal taste -- whatever works best for you as long as its consistent. Simpler's generally better, and worrying about portability to other distros is generally more trouble than its worth, but again that stuff is personal preference For the dir ownership the problem is that currently no package owns those directories. No ownership at all is a much bigger problem than multiple packages owning them (though neither's ideal): [kaboom@fc5test ~]$ rpm -qf /usr/share/themes/Allegro /usr/share/themes/Allegro/openbox-3 file /usr/share/themes/Allegro is not owned by any package file /usr/share/themes/Allegro/openbox-3 is not owned by any package [kaboom@fc5test ~]$ That's the only must-fix left -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review