Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qjackctl - Qt based JACK control application https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191239 ------- Additional Comments From nando@xxxxxxxxxxxxxxxxxx 2006-06-18 22:23 EST ------- (In reply to comment #18) > * %makeinstall is broken (yeah I know, someone should fix it) please use: > make install DESTDIR=$RPM_BUILD_ROOT instead. (Or make that %{__make} ......) Fixed (in which way is makeinstall broken?, I used to not use it and then saw spec files using it and changed over when it works - I know not all packages will use the options it uses, is that the broken behavior?). > * Under %files I see %{_datadir}/icons/qjackctl.png, that is not according to the > freedesktop.org icon standard, it should go under: > %{_datadir}/icons/hicolor/32x32/apps > Where 32x32 is the size of the icon, please do ls /usr/share/icons/hicolor/ > to see the available valid sizes, if the icon doesn't match any pick the > closest. > * Once the icon is in the proper case you must add %post(un) script to update > the icon-cache see: > http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d Fixed. Spec URL: http://ccrma.stanford.edu/planetccrma/extras/qjackctl.spec SRPM URL: http://ccrma.stanford.edu/planetccrma/extras/qjackctl-0.2.20-5.src.rpm (sorry about the broken link before...) (In reply to comment #15) > Well thats enough introduction I guess. The reason I'm introducing myself is > because after stumbling over the SIG I decided to read the fedora-music-list > archives. There I read that you (Fernando) need a sponsor and I can sponsor. Thank you! Much appreciated... A quick question. In my specs I usually include the desktop entry inline with a cat <<EOF, I changed that on request as the guidelines require the desktop entry to be a separate source file. Has anyone ever pointed out that that makes it more difficult to include a full path to the executable that will automatically reflect whatever is in %{_prefix}? I think it is important that what I package executes what I package and not whatever is in the path that happens to match the executable name. Right now I'm just including "Exec=qjackctl" in the desktop file instead of what I used to do which was "Exec=%{_bindir}/qjackctl". I could obviously hack a "perl -p -i -e" inline script to replace a placeholder with the real %{_bindir} but at that point I like it better inline :-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review