Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538 ------- Additional Comments From nando@xxxxxxxxxxxxxxxxxx 2006-06-18 22:22 EST ------- (In reply to comment #4) > * rpmlint output is: > W: qsynth no-version-in-last-changelog > W: qsynth-debuginfo no-version-in-last-changelog > These both must be fixed. > * Source0: http://dl.sf.net/qsynth/qsynth-%{version}.tar.gz > Must be: Source0: http://dl.sf.net/sourceforge/qsynth/qsynth-%{version}.tar.gz > * %makeinstall is broken (yeah I know, someone should fix it) please use: > make install DESTDIR=$RPM_BUILD_ROOT instead. (Or make that %{__make} ......) > * Under %files I see %{_datadir}/icons/qsynth.png, that is not according to the > freedesktop.org icon standard, it should go under: > %{_datadir}/icons/hicolor/32x32/apps > Where 32x32 is the size of the icon, please do ls /usr/share/icons/hicolor/ > to see the available valid sizes, if the icon doesn't match any pick the > closest. > * Once the icon is in the proper case you must add %post(un) script to update > the icon-cache see: > http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d All fixed: Spec URL: http://ccrma.stanford.edu/planetccrma/extras/qsynth.spec SRPM URL: http://ccrma.stanford.edu/planetccrma/extras/qsynth-0.2.5-4.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review