Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Openbox https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195292 peter@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jtorresh@xxxxxxxxx ------- Additional Comments From peter@xxxxxxxxxxxxxxxx 2006-06-14 14:11 EST ------- ------- Additional Comments From jtorresh@xxxxxxxxx 2006-06-12 19:55 EST ------- I don't know if this suggestion belongs in a package-review, but it'd be great if you could include an openbox.desktop file to be installed in /usr/share/xsessions (just like the fluxbox package does) so openbox can be selected from the "Sessions" list in GDM, instead of having to edit who knows what file by hand. By the way, I'm glad you're going to unorphan this package. I love Openbox :) ------- Additional Comments From che666@xxxxxxxxx 2006-06-12 22:12 EST ------- id also say a gdm entry is necassery. ------- Additional Comments From peter@xxxxxxxxxxxxxxxx 2006-06-12 23:31 EST ------- Thanks. Added it in 3.3-0.rc2.2, as suggested. Spec: http://thecodergeek.com/downloads/fedora/openbox.spec SRPM: http://thecodergeek.com/downloads/fedora/openbox-3.3-0.rc2.2.src.rpm ------- Additional Comments From jtorresh@xxxxxxxxx 2006-06-13 00:53 EST ------- Hi, I could be wrong but as far as I understand the NamingGuidelines, this package should have a Release tag similar to "0.2.rc2" instead of "0.rc2.2". The relevant part from the NamingGuidelines: "Release Tag for Pre-Release Packages: 0.%{X}.%{alphatag} Where %{X} is the release number increment, and %{alphatag} is the string that came from the version." Please correct me if I'm mistaken. ------- Additional Comments From peter@xxxxxxxxxxxxxxxx 2006-06-13 01:18 EST ------- Jorge, You are correct about that. I mistakenly thought otherwise; but I checked the guidelines and that's what it should be. I've uploaded new sources to fix this: Spec: http://thecodergeek.com/downloads/fedora/openbox.spec SRPM: http://thecodergeek.com/downloads/fedora/openbox-3.3-0.3.rc2.src.rpm Thanks. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review