Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Re-Review Request: Maelstrom: space combat game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189375 ------- Additional Comments From notting@xxxxxxxxxx 2006-06-02 22:06 EST ------- > E: Maelstrom standard-dir-owned-by-package /usr/share/icons > > - Change the %files line to %{_datadir}/icons/hicolor/48x48/apps/* > > W: Maelstrom buildprereq-use SDL-devel, SDL_net-devel > E: Maelstrom broken-syntax-in-scriptlet-requires BuildPrereq: SDL-devel, > SDL_net-devel > > - Change BuildPrereq: to BuildRequires: Both fixed. > MUSTFIX > ======= > * See rpmlint notes above > * BR: SDL-devel is redundant. It's picked up by SDL_net-devel > * License is GPL, not LGPL > * License file is included in upstream tarball, but not in %doc > * Makefile and Makefile.in should not be included in > /usr/share/Maelstrom/Images or %{_docdir}/Docs All fixed. > * There is a questionable clause in the COPYING file: > "The artwork and sounds used by Maelstrom are copyright Ambrosia Software > (http://www.ambrosiasw.com) and may not be redistributed separately from > the Maelstrom public GPL release." Upstream queried. > SHOULD > ====== > * The following is a nice shell trick, but would be more readable if each > file were removed individually, one per line. > > rm -f $RPM_BUILD_ROOT%{_bindir}/{Maelstrom-netd,macres,playwave,snd2wav} > > ...change to... > > rm -f $RPM_BUILD_ROOT%{_bindir}/Maelstrom-netd > rm -f $RPM_BUILD_ROOT%{_bindir}/macres > (and so on) Awwww. Don't ever read the filesystem spec file. :) > * The BuildRoot tag is almost there. From > http://fedoraproject.org/wiki/Packaging/Guidelines: > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Fixed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review