Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: SS5 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182254 jpmahowald@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From jpmahowald@xxxxxxxxx 2006-05-31 19:34 EST ------- Using ss5-3.5.9-1.src.rpm - rpmlint checks return: E: ss5 configure-without-libdir-spec A configure script is run without specifying the libdir. configure options must be augmented with something like --libdir=%{_libdir}. Built fine, however, with the --with-libpath option. I say ignore. W: ss5 no-version-in-last-changelog The last changelog entry doesn't contain a version. Please insert the version that is coherent with the version of the package and rebuild it. Next release add the version-release to the changelog, right after your email W: ss5 log-files-without-logrotate /var/log/ss5 This package contains files in /var/log/ without adding logrotate configuration for them. logrotate not critical, but may want to consider adding in the future. - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED Do you need a sponsor? I'll be yours if necessary, apply for cvsextras. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review