[Bug 193632] Review Request: tkdnd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tkdnd


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193632





------- Additional Comments From wart@xxxxxxxxxx  2006-05-31 19:01 EST -------
The --libdir argument to configure is necessary due to a poorly written
mkIndex.tcl script.  In addition, upstream seems to have decided to include a
prebuilt dll file in the source tarball.  Naughty upstream!

If you remove the lib/tkdnd/*.dll in %prep and use the sed script below in
%build, then you don't need to pass --libdir in %configure.  This addresses the
problem directly instead of indirectly through --libdir.

%{__sed} -i -e 's#libtkdnd.dll ##' \
    -e "s#^set libdir.*#set libdir $RPM_BUILD_ROOT%{_libdir}#" \
    mkIndex.tcl.in

You should also pass DESTDIR to make install:

make install DESTDIR=$RPM_BUILD_ROOT INSTALL_DATA="install -p"

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]