Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-xmpp - Python library for easy scripting with Jabber https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193281 gauret@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |gauret@xxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From gauret@xxxxxxx 2006-05-28 05:02 EST ------- Review for release 1: * RPM name is OK * Source xmpppy-0.3.1.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * rpmlint looks OK * File list looks OK * Works fine APPROVED (Extremely) minor nitpick: * usually "find doc -type f | xargs chmod a-x" is done in %prep, since it is about "preparing the sources for the rest of the build". -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review