Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-dns - DNS toolkit for Python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193271 gauret@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |gauret@xxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From gauret@xxxxxxx 2006-05-28 05:01 EST ------- Review for release 1: * RPM name is OK * Source dnspython-1.3.5.tar.gz is the same as upstream * Builds fine in mock * rpmlint looks OK * File list looks OK * Works fine APPROVED Minor: * Use of buildroot is not consistant. (wiki: PackagingGuidelines#UsingBuildRootOptFlags) Please change your occurence of %{buildroot} in %check into $RPM_BUILD_ROOT -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review