Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: knemo Network monitor applet. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189088 gauret@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |gauret@xxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From gauret@xxxxxxx 2006-05-20 13:29 EST ------- Needs work: * No downloadable source. Please give the full URL in the Source tag. * Desktop file: vendor should be fedora (wiki: PackagingGuidelines#desktop) * Desktop file: the Categories tag should contain Application and X-Fedora (wiki: PackagingGuidelines#desktop) * The translation files are not properly tagged, use the %find_lang macro (wiki: Packaging/ReviewGuidelines) * Scriptlets: missing "gtk-update-icon-cache" in %post and %postun (wiki: ScriptletSnippets) * Don't rm -rf $RPM_BUILD_ROOT in %prep, it breaks rpm -qi --short-circuit * The "-n %{name}-%{version}" part in %setup is useless, it's already the default * export QTDIR=/usr/lib/qt-3.3/ should be replaced by: unset QTDIR && . %{_sysconfdir}/profile.d/qt.sh export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include and it should be moved at the top of %build * %configure should be moved in %build * The BuildRoot must be cleaned at the beginning of %install * Use make install, not make install-strip. RPM will strip the binaries by itself * INSTALL is useless as a %doc, we're using RPM. * %{_datadir}/*/*/*/* is a too generic, use %{_datadir}/icons/*/*/*/*.png * The directory /usr/share/apps/knemo/ should be owned by the package -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review