Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: PyScript - Postscript graphics with Python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191218 ------- Additional Comments From paultcochrane@xxxxxxxxx 2006-05-15 06:09 EST ------- (In reply to comment #5) > A couple of things: > 1) %prep section: > make it: > %setup -q Done. Spec file is a lot cleaner now. > 2) I read http://fedoraproject.org/wiki/Packaging/Python , you should do that > too. I hinted to replace paths with libdir but in this page you can read about > %{python_sitelib}, use this instead. Done. > 3) use wildcards in the %files section, instead of listing all files seperatly > (see the url in 2 for an example) Done as much as possible. There are some files in the lib/ directory of the PyScript source tree that we don't yet want distributed so I've kept these files specified explicitly. > 4) python setup.py install --prefix=$RPM_BUILD_ROOT/usr still has /usr hardcoded Fixed. Thank you again for your time! I have updated the SRPM and SPEC files, they are at: Spec URL: http://dl.sourceforge.net/sourceforge/pyscript/pyscript.spec SRPM URL: http://dl.sourceforge.net/sourceforge/pyscript/pyscript-0.6-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review