Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qt4: Qt GUI toolkit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188180 ------- Additional Comments From laurent.rineau__fc_extra@xxxxxxxxxxxxxx 2006-05-15 05:33 EST ------- (In reply to comment #37) > %changelog > * Sat May 13 2006 Rex Dieter <rexdieter[AT]users.sf.net> 4.1.2-11 [...] > - pkgconfig files: hardlinks -> relative symlinks, strip -L%{_libdir}/mysql > and -L%%{_builddir}/qt-x11-opensource-src-%%version/lib Actually, I do not really understand why you trip -L%{_libdir}/mysql from pkgconfig file. It might be a FE rule that I am not aware. (In reply to comment #48) > %changelog > * Sat May 14 2006 Rex Dieter <rexdieter[AT]users.sf.net> 4.1.2-14 [...] - docs: don't mark examples as %doc ** rpmlint has new warnings after this change: W: qt4-docs devel-file-in-non-devel-package /usr/lib64/qt4/examples/tools/plugandpaint/plugindialog.h for every header in -examples/. Furthermore, the package guidelines states that a file marked as %doc should not be required by the package: "If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present." (Maybe future versions of rpm will allow to uninstall %doc files, and %lang files.) However, %{qtdir}/bin/qtdemo (in qt4-devel) depends on the headers and sources in %{qtdir}/examples and %{qtdir}/demo. IMHO nothing should be %doc in the -docs subpackage (as in tetex-doc in fc). %{qtdir}/bin/qtdemo should go in qt4-docs, I think. ** Subpackage -docs should be named -doc The packaging guidelines and the review guidelines do not agree on the name of documentation subpackage. "Tom 'spot' Callaway" <tcallawa@xxxxxxxxxx> has admitted on the FE list that it was a typo in the review guidelines: a documentation subpackage should be named -doc. ** There are dandling symlinks in %{_bindir}. It seems that there are some binaries in the bin/ subdirectory of Qt build tree that are not installed. And qt3to4 got the suffix. Proposed patch: @@ -250,10 +250,10 @@ # Make symlinks in %%_bindir mkdir -p %{buildroot}%{_bindir} -pushd bin +pushd %{buildroot}%{qtdir}/bin for i in *; do SUFFIX=4 - [ "$1" == "qt3to4" ] && SUFFIX="" + [ "$i" == "qt3to4" ] && SUFFIX="" ln -s ../%{_lib}/%{qt_dirname}/bin/$i %{buildroot}%{_bindir}/${i}${SUFFIX} done popd -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review