Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qt4: Qt GUI toolkit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188180 ------- Additional Comments From laurent.rineau__fc_extra@xxxxxxxxxxxxxx 2006-05-13 11:49 EST ------- I have not yet looked at the generated RPMs, but I found some odd things: - Your spec file defines a sub-package named "styles", but there is no %files section for it. - Between 4.1.2-6 and 4.1.2-8, the diff shows that you remove LICENSE.QPL from packages. The license of qt4 free edition is GPL/QPL (even if Trolltech tries to make users forget the QPL license). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review