Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: childplay https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190876 ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-05-10 04:04 EST ------- Created an attachment (id=128836) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=128836&action=view) Improved specfile (In reply to comment #3) > > SHOULDFIX > ========= > * Remove the single-quotes from the word 'suite' in the %description. > Done > * Package includes precompiled .pyo files. These should probably be removed > and %ghosted. The python guidelines[1] don't forbid them, but the python > package that I've seen always remove them. > Done > MUSTFIX > ======= > * Missing BR: desktop-file-utils > Fixed > QUESTIONS > ========= > * Why change /usr/bin/env python to /usr/bin/python? The former will > pick up the first python executable in the path, which should be ok. Because leaving it in will make the package "Requires: /usr/bin/env" (rpmbuild does this automaticly). > Even if you decide to change it, you should probably use %{_bindir}/python > instead of hardcoding /usr/bin in the sed command. > Done -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review