Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: childplay https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190876 ------- Additional Comments From wart@xxxxxxxxxx 2006-05-10 02:19 EST ------- MUST ==== * rpmlint output clean * Package and spec file named appropriately * Source matches upstream: 2353509fda8cf7d32c8a10ebd8390370 childsplay-0.81.8.tgz * GPL license ok, license file included * Spec file legible and in Am. English * Builds in mock on: devel-i386, * Locales handled correctly with %find_lang * No shared libs * Not relocatable * Owns directories that it creates * No need for -docs subpackage * RPM_BUILD_ROOT cleaned as needed * No duplicate %files * Permissions look ok * No -devel package needed * .desktop file installed correctly SHOULDFIX ========= * Remove the single-quotes from the word 'suite' in the %description. * Package includes precompiled .pyo files. These should probably be removed and %ghosted. The python guidelines[1] don't forbid them, but the python package that I've seen always remove them. [1] http://fedoraproject.org/wiki/Packaging/Python MUSTFIX ======= * Missing BR: desktop-file-utils QUESTIONS ========= * Why change /usr/bin/env python to /usr/bin/python? The former will pick up the first python executable in the path, which should be ok. Even if you decide to change it, you should probably use %{_bindir}/python instead of hardcoding /usr/bin in the sed command. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review