Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ganymed https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191014 ------- Additional Comments From robert@xxxxxxxxxxxxxxxxx 2006-05-08 10:39 EST ------- (In reply to comment #1) > * Why have all those macro definitions, conditional and otherwise, at the top > instead of just... > %define gcj_support 1 > ? umm Ben Konrath added that part to my initial SPEC, I just thougth it was just to make easy to package it for RHEL https://www.redhat.com/archives/fedora-devel-java-list/2006-April/msg00048.html > > * I've been using %{?dist} in Release tags, like > Release: 1%{?dist} > > * There's a preference to not use macros in Source0. It's something somebody > should be able to wget directly. umm then i need to update my other packages already on extras, > > * Missing '.' at the end of %description. > > * Single line %post[un] bits should look like this... > %post -p %{_bindir}/rebuild-gcj-db > %postun -p %{_bindir}/rebuild-gcj-db > (rpmlint will complain about this) > > Thanks! > The other ones are easy to do :-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review