[Bug 188369] Review Request: ctapi-cyberjack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ctapi-cyberjack


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188369





------- Additional Comments From j.w.r.degoede@xxxxxx  2006-05-07 06:02 EST -------
I've just approved the ctapi-common package (bug 190911). I guess Ville will
import and build this soon.

So we've "solved" the where to put the ctapi library issue. Please modify your
package to install the library under %{_libdir}/ctapi and add:
Requires: %{_libdir}/ctapi

Also please remove the versioning (.0) from ctapi-cyberjack.so, but you should
still pass the -soname flag to the linker, just without the .0, .so files should
always should have an soname set.

I'm not sure what todo with regards to soname versioning for the pcsc
ifd-handler .so file. Ville do you know if these should be versioned or not?

Once we have the versioning of the pcsc ifd-handler .so file figured out please
create yet another version of your package. Sorry for the rough ride for your
first package. As I already said you picked a hard one. Well concider this a
good introduction to the review process and the general community process.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]