Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: svnmailer - Tool to post subversion repository commit information https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180319 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|fedora-extras- |fedora-package- |list@xxxxxxxxxx |review@xxxxxxxxxx jpmahowald@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|roozbeh@xxxxxxxxxxxxx |jpmahowald@xxxxxxxxx OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From jpmahowald@xxxxxxxxx 2006-05-04 21:04 EST ------- The documentation may actually be of some use, as it's needed to generate a config file. But it does make sense to split it off. You may want to remove an annoying extra doc folder by doing in the %files doc section something like %doc docs/* But that's optional. Also a good idea would be a version bump to 1.0.8. For now: - rpmlint checks return clean - package meets naming guidelines - package meets packaging guidelines - license (Apache Software License) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on FC5 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - nothing in %doc affects runtime - no need for .desktop file APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review