Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glibrary-1.0.1 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188435 ------- Additional Comments From ville.skytta@xxxxxx 2006-05-01 12:22 EST ------- (In reply to comment #3) > Much better! The one point (not a blocker) is that you can use: > %{_datadir}/%{name}/ > > instead of > > %{_datadir}/%{name}/* > > Gives you the same end result. Nope, the former results in ownership of the directory in the package (which is desirable in this case), the latter does not. Properly owning dirs is a MUST per the review guidelines. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review