Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: par2cmdline https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190070 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-04-27 20:31 EST ------- Thanks for fixing things up. I'll just respond point by point: The source URL is good; Sourceforge often fails to respond for me, but things usually start to work if you try long enough. Let me try to fix up the %description a bit, using what's in the README: ---- par2cmdline is a program for creating and using PAR2 files to detect damage in data files and repair them if necessary. PAR2 files are usually published in binary newsgroups on Usenet; they apply the data-recovery capability concepts of RAID-like systems to the posting and recovery of multi-part archives. ---- BuildRoot: is now good. Distribution: SuSE 9.1 is gone. The problem with Obsoletes: is that you's behavior can be counter-intuitive, but what you have here is fine. rpmlint is now silent. The only remaining issue is that I didn't notice the test suite upstream (which was dumb of me since it's pretty obvious). Can you add this after %clean: %check make check-TESTS to run the test suite? I checked that it passes on i386 and x86_64. APPROVED. Just add the %check bit when you check in. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review