[Bug 189250] Review Request: python-lxml - ElementTree-like python bindings for libxml2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-lxml - ElementTree-like python bindings for libxml2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189250


pnasrat@xxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From pnasrat@xxxxxxxxxx  2006-04-26 14:30 EST -------
Thanks - builds and runs. Meets review criteria, moving to FE-ACCEPT

>>> import lxml.etree
>>> doc = lxml.etree.parse('example-tutorial-en.xml')
>>> e = doc.xpath('//article[@id="example-tutorial"]')
>>> e
[<Element article at -480fd9e4>

Review as above:
* built on fc5 - tested working
* package meets naming and packaging guidelines. Uses dist tag.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the python template.
* license field matches the actual license.
* license is open source-compatible and included
* source files match upstream:
25e18d86050907f3a088550fe650f841  lxml-0.9.1.tgz
25e18d86050907f3a088550fe650f841  /home/pauln/tmp/lxml-0.9.1.tgz
* BuildRequires are proper.
* builds in mock
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present
* package contains code, not content.
* documentation is relatively small , so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no pkgconfig files.
* no libtool .la files
* not a GUI app so no .desktop


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]