Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: initng https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173459 ------- Additional Comments From enrico.scholz@xxxxxxxxxxxxxxxxxxxxxxxxx 2006-04-24 08:18 EST ------- * I think, the old vs. recent SELinux API check should be implemented in the upstream package (I do not know, whether cmake is powerful enough for that). Else, I would not use 'rpm -q ...' but check the required feature. E.g. with | grep -q only-in-old-api /usr/include/selinux/selinux.h && API=OLD || API= | cmake . -D${API}SELINUX:BOOL=ON ... But I really do not know for what the OLDSELINUX/SELINUX flag is used and can not tell the exact string for 'only-in-old-api'. * there should be appended a '|| :' to the | /usr/sbin/semanage ... | /sbin/restorecon ... calls in %post and %postun, and perhaps '2>/dev/null' too. 'semanage' is not available for FC4. * %postun is buggy; '/sbin/ldconfig' must be moved into the body: | %postun -p /sbin/ldconfig | /usr/sbin/semanage ... * just a minor tweak: use | %install | rm -rf %{buildroot} _doc ~~~~ * the | %post | ... | exit 0 is useless; either %post reached the 'exit 0'; then the last command succeeded with exit code '0' and the complete script will exit with 0. Or, a command failed; then the complete script will abort immediately without seeing the 'exit 0'. * not really wrong, but the '-r' flag can/should be omitted: | %install | ... | rm -rf %{buildroot}/sbin/killall5 Else: * when you want a full review, then provide a complete .src.rpm. * how mature is the i-files syntax? When scripts will have to be rewritten for e.g. 0.70, this will stop me from approving it... Resp.: when published now, can you guarantee, that a) package follows upstream releases, and b) a nightly 'smart update' to a new version will not bring the system into an unusable state? * when attaching spec files to the ticket, a 'text/plain' type shall be assigned instead of 'application/octet-stream' -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.