Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: zaptel-kmod https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177583 andy@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andy@xxxxxxxxxxxx ------- Additional Comments From andy@xxxxxxxxxxxx 2006-04-24 08:18 EST ------- zaptel-ztdummy-250hz.diff.txt:37 +if ((HZ != 1000) || (HZ != 250)) { + printk("ztdummy: This module requires the kernel HZ setting to be 1000 or 250 ticks per second\n"); return -ENODEV; There is a logic problem with that. It should either be - !((HZ = 1000) || (HZ = 250)) or (HZ != 1000) && (HZ != 250) Otherwise, without the RTC, the ztdummy module will not load as it will act exactly the opposite of what it was intended to. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.