[Bug 189656] Review Request: lilypond - A typesetting system for music notation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lilypond - A typesetting system for music notation


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189656





------- Additional Comments From tibbs@xxxxxxxxxxx  2006-04-23 17:27 EST -------
A few quick comments:

Referencing %{_datadir}/locale/ in %files is forbidden; you should
BuildRequires: gettext and use %find_lang.

I'm not sure why RPM would fail to strip your shared libraries; brp-strip-shared
looks like it will plow through everything in the buildroot for anything that
file calls a "shared object".  In addition, I'm concerned that stripping
manually might break the -debuginfo package.

Is it worth adding a desktop file for .ly files?

Be aware that Fedora development has vim 7 which stores its data in
/usr/share/vim/vim70e.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]