Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libGLw https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188974 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2006-04-14 03:30 EST ------- Some quick comments after looking at the spec: * It would be better to have your real name on the bug report. Not a big deal, it is in the spec anyway. * the Buildroot is no the right one http://fedoraproject.org/wiki/Packaging/Guidelines#head-f196e7b2477c2f5dd97ef64e8eacddfb517f1aa1 * no need to conditionalize openmotif support, it should always be true in fedora extras * the non free file shouldn't be distributed. what I do in such cases is provide with a script in SourceXX that unpack the upstream tarball, remove the offending files and repack, such that a reviewer can easily reproduce what you did in the SOURCES directory. An example where I do that is grads (with the script grads-remove-files and the list of files grads-removed-files-list) although you could do more simply since you only have one file to remove. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.