On Tue, Feb 27, 2007 at 12:13:01PM +0100, Matthias Saou wrote: > > Are you interested in counter-examples too? It's not a formal review, > but IMHO definitely highlights some of the possible misunderstandings > people can have from the guidelines : > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230096 > > - No constructive comments, just "MUST" (some wrong) and "SHOULD" > - No indication of it's formal or just some preliminary comments I don't think this is a good example. I can guess that Xavier isn't very experienced, so doing review that may be ameliorated is something normal, and I think that one of the role, of (very) experienced packagers is to point out out in a pedagogical manner his errors. I don't disagree that there are mistakes in the review, but in my opinion learning by doing (mistakes) should be encouraged, so I think that in some sense this review is perfectly right since it shows an inexperienced reviewer who does his best to comment on a review. -- Pat -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
