On Tue, 5 Dec 2006, Mamoru Tasaka wrote:
> Well, I tried to rebuild this package, and I get the following
> rpmlint complaint.
> --------------------------------------------------------
> E: xl2tpd tag-not-utf8 %changelog
I have sacrificed Mr. Karlsen's name.
> E: xl2tpd obsolete-not-provided l2tpd
Fixed.
> E: xl2tpd non-readable /etc/xl2tpd/l2tp-secrets 0600
> E: xl2tpd non-readable /etc/ppp/chap-secrets.sample 0600
My rpmlint does not show this warning.
They are supposed to be non-readable, they contain secrets.
> W: xl2tpd dangerous-command-in-%post mv
My rpmlint does not show this warning
That is for the migration of l2tpd configs:
if [ -f /etc/l2tpd/l2tpd.conf ]
then
echo "Old /etc/l2tpd configuration found, migrating to /etc/xl2tpd"
mv /etc/xl2tpd/xl2tpd.conf /etc/xl2tpd/xl2tpd.conf.rpmsave
cat /etc/l2tpd/l2tpd.conf | sed "s/options.l2tpd/options.xl2tpd/" > /etc/xl2tpd/xl2tpd.conf
mv /etc/ppp/options.xl2tpd /etc/ppp/options.xl2tpd.rpmsave
mv /etc/ppp/options.l2tpd /etc/ppp/options.xl2tpd
mv /etc/xl2tpd/l2tp-secrets /etc/xl2tpd/l2tpd-secrets.rpmsave
cp -a /etc/l2tpd/l2tp-secrets /etc/xl2tpd/l2tp-secrets
fi
How is this dangerous?
> E: xl2tpd no-chkconfig-line /etc/rc.d/init.d/xl2tpd
My rpmlint does not show this warning
Not sure what that refers to, since i have a line:
# chkconfig: - 80 30
> E: xl2tpd tag-not-utf8 %changelog
> E: xl2tpd non-utf8-spec-file xl2tpd.spec
Changed Mr. Karlsen's name.
> W: xl2tpd unversioned-explicit-obsoletes l2tpd
Fixed.
> W: xl2tpd mixed-use-of-spaces-and-tabs (spaces: line 65, tab: line 52)
Fixed.
> E: xl2tpd-debuginfo tag-not-utf8 %changelog
Changed Mr. Karlsen's name.
What version of rpmlint do you have? rpmlint-0.78-2.fc6 only gave the
utf8 warnings and the unversioned warning. I now see:
# rpmlint /usr/src/redhat/SRPMS/xl2tpd-1.1.06-2.src.rpm
[root@bofh devel]#
> I have not yet checked this, however, I think that this package
> should once pass current FE review request check.
Okay. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218408
Whoever has access can delete xl2tpd rpms from the repo.
Mamoru: It seems my bugzilla comment clashed with yours, and both our
comments got lost. I'll add the contents of this email to the new
comment I'll make now.
Paul
--
fedora-extras-list mailing list
fedora-extras-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-extras-list
