On Wed, Jul 05, 2006 at 11:50:41PM +0200, Till Maas wrote: > Hiyas, > > at this time the Packaging-Guidelines do not mention whether or > not %{optflags} should / must be used. They are used everytime %configure is > executed, but there are also packages that do not have a ./configure script > and for this reason would not use the %{optflags}. The flags in %{optflags} > contain not only optimization but also security flags. For this reason I > suggest that the Guidelines state that they have to be used. This will also > help new contributors to know about this. I was persuaded that it was in the Guidelines. I all the reviews I have seen, not using the optflags (with configure or not) was a blocker (there may be valid exceptions though when it is too complicated for example, for example in the cernlib). > As well the Guidelines do not mention that the Source tag with upstream source > should be a url / downloadable. Maybe this can be added, too. Sometimes it is not practical. For example if the upstream source isn't versionned, it may be convenient to rename the file by appending a version string, and leave the upsteam source within comments, for example like (taken from tetex-tex4ht): # renamed to tex4ht-all-YYYYMMDD.zip - based on last timestamp in directory Source1: tex4ht-all-20050228.zip # unversioned upstream source, downloaded with wget -N #Source1 http://www.cse.ohio-state.edu/~gurari/TeX4ht/tex4ht-all.zip Another example is when the upstream source has disappeared and the latest available is within something else, for example in a src.rpm. Admitedly these are exceptions. -- Pat -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list