Ralf Corsepius wrote:
On Fri, 2006-06-09 at 21:29 -0700, Christopher Stone wrote:
Author: xulchris
Update of /cvs/extras/rpms/poker-eval/FC-4
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv29974/FC-4
Modified Files:
poker-eval.spec
%install
-rm -rf %{buildroot}
-make install DESTDIR=%{buildroot}
+%{__rm} -rf %{buildroot}
+%makeinstall
%changelog
+* Fri Jun 09 2006 Christopher Stone <chris.stone@xxxxxxxxx> 131.0-2
+- Add pkgconfig to devel Requires
+- Use macros for system commands
+- Use %%makeinstall macro
Why the %makeinstall? makeinstall is an anachronism and should only be
used if make DESTDIR=... install is nonfunctional.
I don't see the use of %makeinstall being discouraged in the packaging
guidelines or even discussed for that matter.
If this is something that shouldn't be used or whatever, then you should
probably have FESCo add it to the packaging guidelines. A lot (most of
actually) of the packages I have make use of %makeinstall and this is
the first time I have seen it being mentoned.
Michael
--
fedora-extras-list mailing list
fedora-extras-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-extras-list
