Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: torque https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188105 ------- Additional Comments From ed@xxxxxxx 2006-04-17 10:52 EST ------- Hi Garrick, this isn't a full review but I'm hoping to find more time to look at it later this week. good: rpmlint output basically unchanged from previous comments OK - follows naming guidelines OK - license seems acceptable and included OK - spec file is not as simple as it could be and it contains a number of conditional options that are a little time-consuming to read and (try to) understand -- but having looked at them I don't see any actual blockers OK - builds in mock on FC5 i386 OK - dir ownership and permissions look fine OK - libs seem fine and no *.la files OK - code not content nits: - the [ "$RPM_BUILD_ROOT" != "/" ] is not necessary for FE - If you'd like to have the same version of torque in, say, FE4, FE5, and devel then you'll probably want to add %{?dist} per http://fedoraproject.org/wiki/DistTag - perhaps the headers currently located at /usr/include/* could go in a subdir such as /usr/include/torque/* since some of the header files have rather unfortunately generic names (eg. "tm.h") blockers: - How can I verify that the source matches upstream? I found the download pages at: http://www.clusterresources.com/downloads/torque/snapshots/ but I can't seem to find the same .tar.gz file or a way to create an identical one from CVS -- could you please document that step within the spec file as a comment so that I can repeat it? Or perhaps use one of the "official" tar files? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
