Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Finance-Quote https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188261 ------- Additional Comments From paul@xxxxxxxxxxxx 2006-04-10 11:48 EST ------- (In reply to comment #6) > How is it a buildreq? I'll admit, I'm not 100% up on the perl build processes. Strictly speaking it isn't - yet. The Makefile.PL has it as a prerequisite and without it, you get this during the build: Checking if your kit is complete... Looks good Warning: prerequisite HTML::TableExtract 0 not found. Writing Makefile for Finance::Quote Normally that would spell imminent doom when it came to running the test suite (HTML::TableExtract would be needed in order to run any meaningful test), but in this case you get away with it because there isn't actually any test suite. Adding the buildreq now would make the package "ready" for when upstream actually provides a test suite and is just good practice anyway. The find/while/read/grep/mv loop in %prep could be simplified to: find . -name *.pm | xargs %{__sed} -i -e '/^#!.*\/usr\/bin\/perl/d' There is no changelog entry for the -2 revision. Other than that, looks good. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
