Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ratpoison - simplified keyboard-only window manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182040 ------- Additional Comments From kevin@xxxxxxxxx 2006-04-08 16:42 EST ------- The spec in comment #8 seems to be the old spec, but the new one is in the src.rpm, so no problems. ;) fc4 now builds ok, but fc5 and devel fail with: gcc -O2 -g -march=i386 -mcpu=i686 -Wall -O2 -o ratpoison actions.o bar.o completions.o communications.o editor.o events.o format.o frame.o getopt.o getopt1.o globals.o group.o history.o hook.o input.o linkedlist.o main.o manage.o number.o sbuf.o screen.o split.o window.o xinerama.o -lXinerama -lXext -lX11 -lhistory actions.o: In function `cmd_rathold': /home/kevin/rpm/BUILD/ratpoison-1.4.0/src/actions.c:3032: undefined reference to `XTestFakeButtonEvent' /home/kevin/rpm/BUILD/ratpoison-1.4.0/src/actions.c:3030: undefined reference to `XTestFakeButtonEvent' actions.o: In function `cmd_ratclick': /home/kevin/rpm/BUILD/ratpoison-1.4.0/src/actions.c:3012: undefined reference to `XTestFakeButtonEvent' /home/kevin/rpm/BUILD/ratpoison-1.4.0/src/actions.c:3013: undefined reference to `XTestFakeButtonEvent' collect2: ld returned 1 exit status make[2]: *** [ratpoison] Error 1 make[2]: Leaving directory `/home/kevin/rpm/BUILD/ratpoison-1.4.0/src' make[1]: *** [all] Error 2 make[1]: Leaving directory `/home/kevin/rpm/BUILD/ratpoison-1.4.0/src' make: *** [all-recursive] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.43773 (%build) Looks like a missing BuildRequires: libXtst-devel (for fc5, devel only ) The install-info lines aren't quite right, resulting in: Preparing... ########################################### [100%] 1:ratpoison ########################################### [100%] install-info: No dir file specified; try --help for more information. Please look at the Texinfo section of the scriptlets page: http://fedoraproject.org/wiki/ScriptletSnippets Those are the last two blockers I see. Fix those up and I would be happy to approve the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list