Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsdiff - binary diff/patch utility https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186566 matthias@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias@xxxxxxxxxxxx ------- Additional Comments From matthias@xxxxxxxxxxxx 2006-03-29 08:57 EST ------- - The %{!?dist} is wrong, you probably meant %{?dist} :-) - Passing -n %{name}-%{version} to %setup is not needed, as it's the sane default - You're missing a "rm -rf ${RPM_BUILD_ROOT}" as the first line of %install - Why Source0 and Patch1? Would seem more logical to start at Patch0 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
