Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: swaks - A command-line SMTP transaction tester https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=179237 matthias@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias@xxxxxxxxxxxx ------- Additional Comments From matthias@xxxxxxxxxxxx 2006-03-29 08:53 EST ------- A few suggestions : - Remove "A" from the summary : "Command-line SMTP transaction tester" - Use "Buildarch:" insted of longer "BuildArchitectures:", as your headers will look nicer and all aligned :-) - You could use "install -D -p -m 0755 %{SOURCE0} etc." instead of mkdir/cp/chmod - No need to tag man pages as %doc, rpm does that by itself - The forced %attr for the script is redundant with the chmod from %install All the rest looks good. Let me know if you fix some of the above and I can then do a formal review. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
