Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-shout https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181445 dmitry@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmitry@xxxxxxxxxxxx ------- Additional Comments From dmitry@xxxxxxxxxxxx 2006-03-28 07:56 EST ------- I cannot sponsor you, but as I have some skills in php packaging I do some pre-review work here. Remarks/nitpicks: - It seems that included tarball contains a lot of extra data (it is about 3.6Mb before "phpize --clean" and just 360kb after it). Maybe better to ship just pre-phpize tarball as a source. - .spec file must not contain version/release, rename it to "php-shout.spec" - remove leading "A" in the Summary. - IMHO, the Summary can sounds better: "PHP module for communicating with icecast servers" or something similar. - %{php_version} macro is not needed, %{php_extdir} macro can be cleaned a little - Since php-5.1.2-5, the new virtual is provided: "php-api". It should be used for dependencies. An appropriate macro %{apiver} can be auto-determined (see in the patch below). - There is a test stuff in the tarball ("./tests" subdir). After phpize'ing under FC5, it will be possible to run "make test" in the %{check} section (instead of the current fake one derived from php-json package ;)). Currently "make test" fails for me. Perhaps some additional work should be done before the test is run. Anyway, if tests are present, they should be run at rpmbuild time to make sure that all is OK. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
