Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cairomm (C++ bindings for cairo) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182463 bugs.michael@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |bugs.michael@xxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From bugs.michael@xxxxxxx 2006-03-24 18:00 EST ------- Package is in quite good shape. Almost there. These minor issues are left: * missing "BuildRequires: pkgconfig" * cairomm-devel should really "Requires: pkgconfig", because (1) it contains a pkg-config file and (2) the library headers are stored in a path that is unlikely to be found if pkg-config is not used * prefer "make DESTDIR=%{buildroot} install" over %makeinstall, since while the former is de facto standard, the latter is just a hack * AUTHORS %doc file is about libxmlplusplus and points to its home page * README %doc file has libxml++ at the top, very confusing, both files should really be corrected * Also note that the cairomm-devel package contains more than "headers and static library". ;) The very important *.so symlink is included, too. > E: cairomm shlib-with-non-pic-code /usr/lib/libcairomm-1.0.so.0.0.5 Cannot reproduce this on i686, but if it occurs on x86_64, it must be patched to compile everything with -fPIC. Also skim over the build log and check whether you see the configure checks and whether -fPIC is used during compilation: | checking for gcc option to produce PIC... -fPIC | checking if gcc PIC flag -fPIC works... yes | checking for g++ option to produce PIC... -fPIC | checking if g++ PIC flag -fPIC works... yes > W: cairomm unstripped-binary-or-object /usr/lib/libcairomm-1.0.so.0.0.5 Cannot reproduce. When you get this, most likely you either don't have the redhat-rpm-config package installed or you've disabled creation of debuginfo packages via ~/.rpmmacros: %debug_package %{nil} As a hint at the bottom: | %{_includedir}/cairomm-1.0/* vs. | %{_includedir}/cairomm-1.0 Even better to the eyes, since you see it's a directory (!): %{_includedir}/cairomm-1.0/ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
