Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: raidem - 2d top-down shoot'em up https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185257 ------- Additional Comments From wart@xxxxxxxxxx 2006-03-15 02:31 EST ------- rpmlint warnings: W: raidem invalid-license zlib License W: raidem-debuginfo invalid-license zlib License These can be ignored. This is an acceptible license. W: raidem uncompressed-zip /usr/share/raidem/data/wraith.zip W: raidem uncompressed-zip /usr/share/raidem/data/proj-maser.zip W: raidem uncompressed-zip /usr/share/raidem/data/sea-urchin.zip W: raidem uncompressed-zip /usr/share/raidem/data/conquerer.zip W: raidem uncompressed-zip /usr/share/raidem/data/spirtle.zip W: raidem uncompressed-zip /usr/share/raidem/data/zippy.zip W: raidem uncompressed-zip /usr/share/raidem/data/bolt.zip W: raidem uncompressed-zip /usr/share/raidem/data/schemer.zip W: raidem uncompressed-zip /usr/share/raidem/data/proj-pulselaser.zip These can also be ignored. These files contain game data that are extracted by the game engine at runtime. MUST ==== * Package and spec named appropriately * License 'zlib' ok, license file included * spec file legible and in Am. English * Builds and runs on FC-5 i386 * No excessive or inappropriate BR: or Requires: * No locales * No shared libraries * Not relocatable * Owns all directories that it creates * No duplicates %files * Permissions look ok * No -devel package necessary * Contains both code and permissible content (game data) * Macro use is consistent and sane * buildroot cleaned during %install and %clean * No .la archives or static libs * desktop file included, looks ok NON-BLOCKING ============ * Source does not match upstream, for a good reason. Upstream source contains a mp3 encoder that can't be included in FE. The game still functions without it, so the offending code has been removed. MUSTFIX ======= * Delete the duplicate copies of the various libs during %prep, not by modifying the upstream tarball. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
