Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: SS5 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182254 ------- Additional Comments From jpmahowald@xxxxxxxxx 2006-03-14 18:21 EST ------- * Copyright tag still needs work. Use simply GPL. * The group does not exist in rpm's GROUPS file, use something like Applications/Internet * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) This enables multiple users to build on the same machine (wiki: PackagingGuidelines#BuildRoot) * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * No downloadable source. Please give the full URL in the Source tag. * Missing URL tag to point at the project's home page * Do not tag man pages with %doc, rpm knows what to do with them * Need to include directory /usr/lib/ss5/ in the %files listing -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
