Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ftnchek - Static analyzer for Fortran 77 programs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184305 ------- Additional Comments From orion@xxxxxxxxxxxxx 2006-03-08 12:28 EST ------- Thanks for the review! (In reply to comment #1) > 1. The RPM CFLAGS are not set. Here is a sed one-liner that solves that. You may > prefer a patch, do what you prefer: > > sed -i -e 's/CFLAGS="-DUNIX.*"//' configure > I also did: export CFLAGS="$RPM_OPT_FLAGS -DUNIX" as it appears that the UNIX flag is still required. > 2. you don't install the emacs stuff. Not a big deal. If you want to package it, > you may want to have them in a subpackage ftncheck-emacs. Here is how I do to > have the emacs files in the buildroot: > > mkdir -p $RPM_BUILD_ROOT%{_datadir}/emacs/site-lisp > %makeinstall datadir=$RPM_BUILD_ROOT%{_datadir}/ftnchek \ > lispdir=$RPM_BUILD_ROOT%{_datadir}/emacs/site-lisp Made an emacs sub-package. I also added a BR on emacs so the .elc file would be built. > 3. I prefer something like > %{_mandir}/man1/dcl2inc.1* > instead of > %{_mandir}/man1/dcl2inc.1.gz > such that it works if man pages are no gzipped, or are bzip2ed and so on. It is > my personal taste Good idea > 4. you should add FAQ and PATCHES in %doc done. New version: http://www.cora.nwra.com/~orion/fedora/ftnchek.spec http://www.cora.nwra.com/~orion/fedora/ftnchek-3.3.1-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
