Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: emacs-muse https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181404 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-03-05 14:56 EST ------- Greetings, here is a review: MUST items: OK - Package name good. OK - Spec file name matches OK - Package guidelines OK - Licsense. OK - License field matches in spec. OK - Spec in american english OK - Spec legible OK - Md5sum of source from upstream 96a074a0e7d5cc7b7f54012df574d6cf muse-3.02.6a.tar.gz 96a074a0e7d5cc7b7f54012df574d6cf muse-3.02.6a.tar.gz.1 OK - Compiles and builds on one arch at least. OK - no Forbidden buildrequires included. OK - Owns all directories it creates. OK - No duplicate files in %files listing. OK - Permissions on files correct. OK - Clean section correct. OK - Macros consistant. OK - Code not content. OK - Docs must not affect runtime. OK - Doesn't own any files/dirs that are already owned by others. blockers: 1. missing BuildRequires: texinfo 2. rpmlint issues: E: muse info-dir-file /usr/share/info/dir W: muse incoherent-version-in-changelog 3.02.6a 3.02.6a-2 W: muse doc-file-dependency /usr/share/doc/muse-3.02.6a/examples/johnw/publish-johnw /bin/bash W: muse doc-file-dependency /usr/share/doc/muse-3.02.6a/examples/publish-project /bin/bash W: emacs-muse no-documentation W: emacs-muse-el no-documentation W: xemacs-muse-el no-documentation W: xemacs-muse no-documentation all can be ignored, except for the Error with info-dir-file. That file is created when you build as root, suggest: rm -f $RPM_BUILD_ROOT/usr/share/info/dir in install. nits: 3. Might ask upstream to start including the GPL COPYING file with the release. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
