Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnomeradio - Graphical FM-Tuner program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177105 ------- Additional Comments From bugs.michael@xxxxxxx 2006-03-05 07:10 EST ------- * Missing BuildRequires gettext * LIRC is also available in Extras (lirc-devel). * rpmlint /home/qa/tmp/rpm/RPMS/gnomeradio-1.6-1.i386.rpm W: gnomeradio conffile-without-noreplace-flag /etc/gconf/schemas/gnomeradio.sche mas It should not be marked %config. * /usr/share/pixmaps/radio.png This is pollution of the global pixmaps namespace and should be avoided. The name "radio.png" is way too generic. The package stores "gnomeradio.png" in the same directory, which creates a slightly better namespace. Suggest renaming radio.png, also in the .desktop file. * $ sudo rpm -ivh -p gnomeradio-1.6-1.i386.rpm > Preparing... ########################################### [100%] > 1:gnomeradio ########################################### [100%] > gconfd-2: no process killed Killing gconfd is no longer necessary in FC5, and in case it would be necessary, make it shut up by redirecting its output. It is killed more than once in the scriptlets, which is a guarantee for this warning. * BuildRequires: gtk2-devel libgnomeui-devel Only if you're into "optimising away" redundant build requirements, notice that libgnomeui-devel requires gtk2-devel and glib2-devel already. Else add a comment to make it explicit that _your_ package also depends on the glib API directly (glib2-devel). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
