Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: worminator - Sidescrolling platform and shoot'em up action-game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183969 wart@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From wart@xxxxxxxxxx 2006-03-04 20:10 EST ------- MUST ==== * rpmlint output clean (worminator only) * Package named correctly * GPL license OK. Thanks for including the license change discussion in %doc * spec file legible, in Am. English * Source matches upstream (srpm for -data not provided) * Successfully compiles and builds on at least one platform (FC-4 x86_64) * no locale data, shared libraries, or static libraries * No excessive Requires: or BR: * Summary and description ok * macro use consistent * Game content permissible * -data package owns the directory that it creates. * Not relocatable * %doc does not affect runtime * GAMES SIG MUST ============= * application and data packaged separately * Data in %{datadir}/games permitted (see below) * spec file group ok * license file and change discussion included * file ownership ok SHOULD ====== * Builds cleanly in mock for FC-4 i386, FC-4 x86_64, and FC-5 i386 MUSTFIX ======= * Data should be a noarch package. Use: BuildArch: noarch This will also clean up the rpmlint error on the -data package. * desktop file category incorrect. It should be: Category: Application;Game;ArcadeGame; * Segfaults on FC4-x86_64. strace shows that the game hangs after the segfault, leaving a lingering worminator process. * Started up on FC5-i386, but locked up during the tutorial. SHOULDFIX ========= * Data files should be put in /usr/share/worminator, not /usr/share/games/worminator. I realize there is still a discussion on the Games SIG regarding this, so I won't consider it a blocker. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
